Conversation
- Add stellar-mainnet and stellar-testnet to network configurations - Add relevant Stellar icons to public assets - Update WalletConnect to handle Stellar - Update database schema to support Stellar networks in DiscordServerConfig - Extend component props to support stellar network type - Add Stellar wallet display support with XLM balance - Fix Stellar SDK type issues for transaction source handling - Fix WatchTowerLogger type compatibility - Fix React hooks rules violations by moving conditional routing after hooks
|
@Marchand-Nicolas, if you prefer, I can push a commit that performs the user's identity verification without either of the below, esp. on mainnet;
|
Marchand-Nicolas
left a comment
Marchand-Nicolas
left a comment
There was a problem hiding this comment.
Great job! Well done!!
It's working perfectly on testnet, but it doesn't work on mainnet, I have this error when signing:
I guess you have to change the message a bit on mainnet
.env.local.example
Outdated
| WATCHTOWER_TOKEN=xxx | ||
| LOG_EVERY_X_BLOCK=1 No newline at end of file | ||
| LOG_EVERY_X_BLOCK=1 | ||
| DATABASE_URL=postgresql://host:password@localhost:5432/db_name |
There was a problem hiding this comment.
Please remove those env variables (DATABASE_URL, NEXT_PUBLIC_STELLAR_ENABLED).
Instead of having NEXT_PUBLIC_STELLAR_ENABLED, just make it always enabled (If we want to disable it, we can just remove it from networks.json)
| "label": "Starknet Mainnet", | ||
| "name": "mainnet", | ||
| "url": "https://starknet.preview.apibara.org", | ||
| "indexer": true, |
There was a problem hiding this comment.
Keep this one to true (for your test you can definitely disable it, but please don't commit it)
| try { | ||
| if (networkName === "ethereum-mainnet" && ETHEREUM_ENABLED) { | ||
| // Check if it's a Stellar network | ||
| if (network.chain === "stellar") { |
There was a problem hiding this comment.
No need to check if it's stellar. On this page it's always ethereum
hooks/useUnifiedWalletConnection.tsx
Outdated
| @@ -0,0 +1,115 @@ | |||
| import { useCallback, useState } from "react"; | |||
There was a problem hiding this comment.
I think this hook is not used, so you can delete it
pages/api/verify-stellar.ts
Outdated
| where: { | ||
| discordServerId: body.discordServerId, | ||
| discordMemberId: body.discordMemberId, | ||
| starknetNetwork: body.network, // This field might need to be renamed to support multiple chains |
There was a problem hiding this comment.
I guess you can remove this comment ?
|
All duly noted, ser! |
|
Should finalize it all in a few, ser. |
Resolved conflicts: - configs/networks.json: Kept our Horizon API URLs and testnet support - types/networks.ts: Kept our organized type structure with ChainType - verify-stellar page: Kept our full implementation vs placeholder - public/assets: Renamed stellar-icon.png to stellar-icon1.png to keep both versions Merged incoming changes: - Dashboard analytics section from PR starkyorg#247 - Download button styles updates
- Added StellarAccount type - Extended networkType prop to include "stellar" - Added Stellar address handling in getAddress()
- Added "Stellar wallet" label display - Added XLM balance display with proper formatting - Extended networkType prop to include "stellar" - Added Stellar network icon mapping (/assets/stellar-icon.png) - Added "Stellar network:" label
|
@Marchand-Nicolas this is good for a merge. 
|
2 participants
Implement Stellar Wallet Connection Support
Summary
Added comprehensive Stellar blockchain wallet connection functionality with support for both Testnet and Mainnet networks.
Key Changes
Features
UI of Changes
Files Added/Modified