FR: Allow Marker Screenshot Generation Unconditionally #6433
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to generate marker screenshots independently from marker video previews. Previously, the "Marker Screenshots" option was disabled unless "Marker Previews" was also enabled, forcing users who only wanted static marker screenshots to also generate video preview files.
The implementation adds a
VideoPreviewflag toGenerateMarkersTaskto make video preview generation conditional, matching howImagePreviewandScreenshotalready worked. The task queuing logic now triggers when either option is selected, and themarkerExists()check was updated to correctly handle the case where only screenshots are requested.On the UI side, the disabled dependency was removed from the marker screenshot checkbox.
Fixes: #5841