fix: retry JSON unmarshal after fixing invalid backslash escapes #6469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello, after pulling the fix branch, I compiled the executable file. However, the issue persists after running it. Could you help compile it into a Windows executable file. |
Collaborator
It's available from https://github.com/stashapp/stash/actions/runs/20627718550 |
Collaborator
|
This is an invalid fix for a problem that should be addressed on the plugin side. It's the plugins responsibility to ensure that the output is valid JSON. This PR is filled with duplicated code and tries to address this issue across all instances of json decoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to recover from plugin outputs containing invalid backslash escapes by fixing and retrying JSON unmarshal in pkg/plugin/raw.go and pkg/javascript/gql.go.