make ImageCard patchable for plugin extensibility #6470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Overlaps with #6463 |
Collaborator
|
With #6463 merged, this PR needs to be updated to resolve the conflicts. |
Collaborator
Author
|
I'll look at resolving the conflicts this week |
Refactor ImageCard component to use PatchComponent wrapper. Changes: - Wrap ImageCard and sub-components with PatchComponent - Extract ImageCardPopovers, ImageCardDetails, ImageCardOverlays, ImageCardImage as separate patchable components
cj12312021
force-pushed
the
feature/patchable-image-card
branch
from
a1d1d2e to
ad00973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #6463 (which made
ImageCardpatchable) by adding sub-component granularity for better plugin extensibility.ImageCardPopovers,ImageCardDetails,ImageCardOverlays,ImageCardImage) as separate patchable componentsSceneCard,GalleryCard, andPerformerCardChanges
The refactoring mirrors the structure of other patchable card components:
ImageCard- main component, patchable (from Plugin API more patchable components #6463)ImageCard.Popovers- tag, performer, gallery popoversImageCard.Details- date and descriptionImageCard.Overlays- studio overlayImageCard.Image- image preview and rating banner