-
-
Notifications
You must be signed in to change notification settings - Fork 981
Add studio image scraping from Stash-box endpoints #6479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add studio image scraping from Stash-box endpoints #6479
Conversation
|
I'm looking into a CSS tweak to fix that visual bug where the logo image overflows outside of its area like the last screenshot I have there. |
|
Studio image problem fixed with 1de6675 |
Implements comprehensive studio image scraping with: - StashBox integration via StudioStashBoxModal component - URL-based web scraping via StudioScrapeDialog component - Scraper menu integration in studio editor - Basic English localization (en-GB) This feature allows users to import studio images from: 1. StashBox search by studio name 2. Direct URL scraping via configured scrapers UI components include modal dialogs for search results and scraper output with image preview and import functionality.
This fixes an issue where newly added Stash IDs wouldn't appear in the component until the page was refreshed, by forcing a remount when the studio data changes.
This completes internationalization support for the scraper menu across all 26 supported languages.
This improves visibility and accessibility of scraping features by placing them in a more prominent location.
1de6675 to
401e2d8
Compare
WithoutPants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the i8n changes to non en-GB locales.
Forgot about that part. That's reverted now. I also noticed the conflicts, so I resolved those conflicts. I'm building again locally to test because I noticed that the |
|
All good, still. No visual change on the web ui side. |
The onSaveAndNewClick function was defined but never called anywhere in the StudioEditPanel component. There is no "Save and New" button in the UI that would invoke this function, causing a TypeScript lint error. Changes: - Remove onSaveAndNewClick function definition This fixes the @typescript-eslint/no-unused-vars lint error at line 152.
Ran Prettier to fix formatting issues in multiple files. The main changes are line ending normalization (LF to CRLF) and removal of trailing whitespace. Changes: - Normalize line endings in filters.graphql - Normalize line endings in package.json - Remove trailing whitespace in StudioEditPanel.tsx All linters now pass (ESLint, TypeScript, Stylelint, Prettier, golangci-lint, go fmt).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow! Thanks for catching that! That was not intentional. I marked this PR as a draft until I fix that. It might not be today because I'm about to go to bed soon, though. |




Summary
Adds the ability to scrape and import studio logo images from Stash-box endpoints (like StashDB) directly from the studio edit page.
Motivation
When studios are initially created through regular web scrapers (rather than Stash-box endpoints), their logo images are often not imported. This PR addresses the workflow gap by making it easy to retroactively import studio images from Stash-box sources without having to manually download and upload them.
Previously, adding a logo to an existing studio required:
This PR streamlines that process to just a few clicks using Stash-box endpoints.
Changes
Core Features:
UI/UX Improvements:
Technical Details:
.details-editbutton bar to use arenderButtons()function (modeled after the Performers detail edit page pattern). The previous implementation only allowed custom buttons to be appended to the right side of the "Set Image" and "Clear Image" buttons, making it impossible to control button ordering. The new approach provides consistent button layout matching the Performers page, which users are already familiar with.scrape_queryandscrape_withstrings across all locale files)Screenshots
Testing