Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the scraper package to improve (hopefully) clarity, and prepare for further extensibility.
configtype (representing the scraper yml file) has been renamed toDefinitionandconfig.gohas been renamed todefinition.go.Definitionis a clearer name for it. The sub-sections have had their type names adjusted as well and their definitions tightened up to only include fields related to them.grouptype has been renamed todefinedScraper, to illustrate that it is a scraper derived from aDefinitioninstance. It's constructor has been renamed toscraperFromDefinition, and it's file has been renamed fromgroup.gotodefined_scraper.gomapped.gofile has been split into multiple files with each file focused on a particular aspect of the mapping functionalityTODO: integration testing