Image phash generation #6497
Open
Image phash generation #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gykes
reviewed
Jan 17, 2026
Comment on lines
+1098
to
+1104
| if distance == 0 { | ||
| // use the default handler | ||
| intCriterionHandler(&models.IntCriterionInput{ | ||
| Value: int(value), | ||
| Modifier: phashDistance.Modifier, | ||
| }, "fingerprints_phash.fingerprint", nil)(ctx, f) | ||
| } |
Collaborator
There was a problem hiding this comment.
Should there be a return after this block? When distance is 0 it calls intcriterionHandler then falls through to the switch default again, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to generate, view and filter image perceptual hashes. Uses the existing
goimagehashlibrary for generating perceptual hashes, and stores them in thephashfingerprint type.Phashfield to theFile Infotab in the image detail panel. Provides a link to show images with the same phash.Phashfilter option, functioning the same as the scene filter criterion.