Refactor file scanning and handling logic #6498
Open
+431
−500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved directory walking and queuing functionality into scan task code
WithoutPants
added
chore
|
This pull request has been mentioned on Stash. There might be relevant details there: https://discourse.stashapp.cc/t/stash-v0-31-release-development-thread/4881/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory work for a future synchronous
scanFilegraphql interface. This PR moves the directory walking and queuing functionality out of thefilepackage and into the calling scan task code. Includes removal of some vestigial functionality and some refactoring. No specific regressions are expected, but given the complexity of the scan code some regression testing will be necessary.