feat: StashAnalytics send GENERIC_CLICK events #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| else | ||
| { | ||
| value = kvp.Value.ToString(); | ||
| } |
There was a problem hiding this comment.
Bug: JSON Serialization Fails Due to Locale Formatting
The ConvertDictionaryToJson method's manual serialization can produce malformed JSON. It uses locale-dependent formatting for numeric values and inserts other object types unquoted, causing API requests to fail.
dinosoeren
commented
Oct 29, 2025
| void OnShopButtonClick() | ||
| { | ||
| // Track the click with just element ID and screen name | ||
| StashSDK.TrackClick("shop_button", "main_menu"); |
Collaborator
Author
There was a problem hiding this comment.
@huda-stash let's make this even more generic StashSDK.TrackEvent("event_id", "event_type", "event_target", "screen_name")
e.g. StashSDK.TrackEvent("click_pay", "CLICK", "buy_button", "main_menu")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds analytics click tracking (GENERIC_CLICK) with
StashAnalyticsandStashSDK, a coroutine runner, a sample usage script, and README documentation.StashAnalytics: sendGENERIC_CLICKevents to/sdk/event/log_event(env-aware endpoints), including device/build metadata and optional params; manual JSON payload shaping.CoroutineRunner: singletonMonoBehaviourto run coroutines from non-MonoBehaviour code.StashSDK: initialization andTrackClickAPI plus getters and init check, delegating toStashAnalyticsviaCoroutineRunner.Stash.Samples/ClickTrackingExample: demonstrates initialization and multiple click-tracking scenarios (basic, custom data, navigation, etc.).README.md: adds Event Tracking usage examples and updates components table to include analytics.Written by Cursor Bugbot for commit 7ee143a. This will update automatically on new commits. Configure here.