Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Support search_index tag supplemental data #312

Merged
merged 4 commits into from
Aug 4, 2023
Merged

[5.x] Support search_index tag supplemental data #312

merged 4 commits into from
Aug 4, 2023

Conversation

ryanmitchell
Copy link
Contributor

Fixes #311 by supporting setSupplement and retrieval of supplemental data

duncanmcclean
duncanmcclean approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

I've just added a return $this on the supplement method so newAugmentedInstance still works 😅

@duncanmcclean duncanmcclean changed the title Support search_index tag supplemental data [5.x] Support search_index tag supplemental data Aug 4, 2023
@duncanmcclean duncanmcclean merged commit 156d8d4 into statamic-rad-pack:5.x Aug 4, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Released as part of v5.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmcclean duncanmcclean duncanmcclean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call to undefined method DoubleThreeDigital\Runway\Search\Searchable::setSupplement()
2 participants
@ryanmitchell @duncanmcclean