[5.x] Fix blueprint error when publishing Eloquent Driver migrations #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sets' of github.com:doublethreedigital/runway into fix/blueprints-error-when-publishing-eloquent-driver-assets
duncanmcclean
changed the title
duncanmcclean
deleted the
fix/blueprints-error-when-publishing-eloquent-driver-assets
branch
|
Released as part of v5.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when setting up the Eloquent Driver alongside Runway.
Essentially, when you're in the process of migrating to the Eloquent driver, you change the repositories, then run a vendor:publish command to publish the migrations.
However, when trying to publish the migrations (or run any other artisan commands for that matter), you'd see an error relating to blueprints. This was happening as Runway was trying to "discover" the resources from the configuration file, including looking up its blueprint.
This PR fixes the issue by catching any exceptions when finding blueprints, then ignoring the resource if the app is running in the console.
Fixes #319.