Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Don’t save fields with save set to false #353

Merged
merged 5 commits into from
Oct 20, 2023
Merged

[5.x] Don’t save fields with save set to false #353

merged 5 commits into from
Oct 20, 2023

Conversation

edalzell
Copy link
Contributor

Need to re-open #336.

New use case is that I need a field to be not saved and editable in the CP. Using visibility:computed means that the field is not editable in the CP.

@edalzell edalzell changed the title Don’t save fields with save set to false [5.x] Don’t save fields with save set to false Oct 20, 2023
@edalzell edalzell changed the title [5.x] Don’t save fields with save set to false [5.x] Don’t save fields with save set to false Oct 20, 2023
@edalzell
Copy link
Contributor Author

Still need to update the tests as they reference don't_save which is not the correct config field handle

@duncanmcclean
Copy link
Member

duncanmcclean commented Oct 20, 2023

Still need to update the tests as they reference don't_save which is not the correct config field handle

Do you? dont_save is just the handle of the field in the blueprint we're using for testing. The setting itself is called save. I think it's fine to leave it how it is at the moment.

@duncanmcclean duncanmcclean merged commit b3865d7 into statamic-rad-pack:5.x Oct 20, 2023
5 of 6 checks passed
@github-actions
Copy link

Released as part of v5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants