Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Only bind resource on cp routes #367

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[6.x] Only bind resource on cp routes #367

merged 3 commits into from
Nov 7, 2023

Conversation

ryanmitchell
Copy link
Contributor

No description provided.

@ryanmitchell ryanmitchell changed the base branch from 5.x to 6.x November 7, 2023 09:13
@ryanmitchell ryanmitchell changed the title Only bind resource on cp routes [6.x] Only bind resource on cp routes Nov 7, 2023
duncanmcclean
duncanmcclean requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 🙈

Although it seems to be working fine in the Control Panel, the tests seem to be failing. Would you be able to take a look if you get a chance? No worries if not - I can loop back to it when I'm back on Runway.

@ryanmitchell
Copy link
Contributor Author

Yeah I will do - leave it with me.

duncanmcclean
duncanmcclean approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@duncanmcclean duncanmcclean merged commit 1815487 into statamic-rad-pack:6.x Nov 7, 2023
5 checks passed
@ryanmitchell ryanmitchell deleted the fix/only-bind-on-cp-routes branch November 7, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmcclean duncanmcclean duncanmcclean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmitchell @duncanmcclean