[7.x] Allow search_indexes on resources #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Thanks again for this pull request!
I've added a test to cover the new search_index setting in both of the fieldtype's. I also added Runway::discoverResources() to your test, otherwise the search_index setting wouldn't actually end up being set on the resource.
However, it seems like all three of these tests are failing. Would you be able to take a look when you get a chance?
duncanmcclean
approved these changes
Jun 17, 2024
|
Released as part of v7.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify a
search_indexon resources to use a Statamic search index in both the CP field type and the listing view.Closes #501