Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Refactor the HasMany fieldtype #556

Merged
merged 17 commits into from
Jul 12, 2024
Merged

[7.x] Refactor the HasMany fieldtype #556

merged 17 commits into from
Jul 12, 2024

Commits on Jul 11, 2024

  1. Refactor how relationships get saved

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8c6b67b View commit details
    Browse the repository at this point in the history

  2. Prevent Has Many values from being saved in the traditional sense

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ac00e7e View commit details
    Browse the repository at this point in the history

  3. Ensure model gets refreshed before returning values

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4c1e52e View commit details
    Browse the repository at this point in the history

  4. Get revision saving working

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    99870da View commit details
    Browse the repository at this point in the history

  5. Allow for arrays of IDs in the HasManyFieldtype::preProcess method 

    Previously, it only accepted arrays of `Model` objects (except for when it was being called on a non-runway route, like an entry save).
    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1325a59 View commit details
    Browse the repository at this point in the history

  6. Relationship values should fallback to null

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    785bf8a View commit details
    Browse the repository at this point in the history

  7. Ensure models don't disappear after saving revisions

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ca67f03 View commit details
    Browse the repository at this point in the history

  8. Handle "committing" relationship updates when publishing revisions

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    261e3a6 View commit details
    Browse the repository at this point in the history

  9. Fix styling

    @duncanmcclean @github-actions
    duncanmcclean authored and github-actions[bot] committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    89212fe View commit details
    Browse the repository at this point in the history

  10. Just in case there's no field...

    @duncanmcclean
    duncanmcclean committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e906f7b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add tests to cover removing related models

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    824dcb9 View commit details
    Browse the repository at this point in the history

  2. Refactor relationship code

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6d6378a View commit details
    Browse the repository at this point in the history

  3. $values seems like a better name

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    73370af View commit details
    Browse the repository at this point in the history

  4. wip

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b29fde7 View commit details
    Browse the repository at this point in the history

  5. wip

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    569e836 View commit details
    Browse the repository at this point in the history

  6. wip

    @duncanmcclean
    duncanmcclean committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f69073f View commit details
    Browse the repository at this point in the history

  7. Fix styling

    @duncanmcclean @github-actions
    duncanmcclean authored and github-actions[bot] committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    73cae86 View commit details
    Browse the repository at this point in the history