Move nitro-protocol into packages directory
#1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nitro-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nitro-gui canceled.
|
✅ Deploy Preview for nitrodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
geoknee
force-pushed
the
really-move-nitro-protocol2
branch
2 times, most recently
from
8c38f4e
to
6d5f4ac
Compare
Testing and linting get handled by our yarn workflow
This reverts commit 1663868.
These env vars get set in test/environment.d.ts
This means vs code won't report linting errors for undefined env vars
geoknee
force-pushed
the
really-move-nitro-protocol2
branch
from
6d5f4ac
to
63cc909
Compare
bitwiseguy
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten version of #1638. Closes #1626