Wire up "payment channel updated" events stream to demo #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nitro-payment-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
geoknee
commented
Oct 3, 2023
Comment on lines
+147
to
+153
| // It's possible the channel updated before we registered the handler above, so | ||
| // query the channel once now to get the latest information: | ||
|
|
||
| setPaymentChannelInfo( | ||
| await nitroClient?.GetPaymentChannel(result.ChannelId) | ||
| ); |
There was a problem hiding this comment.
This is a pretty common issue and makes for pretty bad DX. Perhaps a smarter event queue could be used in place of an event emitter.
geoknee
commented
Oct 3, 2023
| @@ -182,25 +177,17 @@ export default function App() { | |||
| nitroClient, | |||
| (progress) => { | |||
| setDownloadProgress(progress); | |||
| updateChannelInfo(paymentChannelInfo.ID); | |||
There was a problem hiding this comment.
This is the nub of the change. Instead of reaching out with http queries each time we think the channel will have changed, we just listen for events being pushed to us. This should cut down on a bit of latency, I think (round trip vs half round trip).
doesn't seem to be firing at the moment
geoknee
force-pushed
the
ts-payment-channel-updated-events-demo
branch
from
58e67fb
to
7c6e3f5
Compare
✅ Deploy Preview for nitrodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lalexgap
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the demo to hook the UI into events rather than using timeouts + polling.