Fix bug in chain event resubscribe #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for nitrodocs processing.
|
✅ Deploy Preview for nitro-payment-demo canceled.
|
geoknee
approved these changes
Oct 9, 2023
bitwiseguy
commented
Oct 9, 2023
| errorChan <- fmt.Errorf("subscribeFilterLogs failed to resubscribe") | ||
| return | ||
| } | ||
| }() | ||
|
|
||
| case <-time.After(RESUB_INTERVAL): |
There was a problem hiding this comment.
Probably out of scope for this PR, but a thought that came to mind: we are intentionally closing the websocket connection every 15 seconds, then catching that error and resubscribing. It seems like polling the chain every 15 seconds instead of setting up a 15-second long subscription would be more efficient. Further details noted in this issue: #1798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug fixed in this PR was causing the cloud nodes to crash repeatedly because even when resubscribing to chain events was successful, an error was being sent on the
errorChan, which triggers a panic. The fix involves the use of aresubscribedboolean flag to indicate if an error should be sent on theerrorChanor not