Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace folders as cwd for remote notebooks #1931

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Jan 27, 2025

Workspace folders now serve as the current working directory for remote notebooks. This is necessary for shebang cell runs.

When no workspace is detected, it defaults to using a temporary directory.

@pastuxso pastuxso force-pushed the cris/remote-notebooks-shebang-support branch 2 times, most recently from 3cdd877 to 48a1ac2 Compare January 28, 2025 00:16
@pastuxso pastuxso force-pushed the cris/remote-notebooks-shebang-support branch from 48a1ac2 to fd79e45 Compare January 28, 2025 00:18
@pastuxso pastuxso requested a review from sourishkrout January 28, 2025 00:19
@pastuxso pastuxso marked this pull request as ready for review January 28, 2025 00:31
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@sourishkrout sourishkrout merged commit 17a6459 into main Jan 28, 2025
1 check passed
@sourishkrout sourishkrout deleted the cris/remote-notebooks-shebang-support branch January 28, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants