Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering for non-tty output (non-interactive) in the vscode-integrated terminal #1957

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

sourishkrout
Copy link
Member

This mimics what we do in the notebook and makes the terminal output more readable. Especially if both stdout and stderr are interspersed.

The difference is with buffering:
image

Before the change without buffering:
image

Example cell (interactive: false): https://gist.github.com/sourishkrout/d61c3226473afdc030951bdc167d15cd#file-01jkvp47gcjh2s6mgysf16j06b-md

Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At my end it works!

@sourishkrout sourishkrout merged commit 2500956 into main Feb 12, 2025
1 check passed
@sourishkrout sourishkrout deleted the seb/buffer-non-tty branch February 12, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants