Skip to content

Commit

Permalink
fix: change tag value
Browse files Browse the repository at this point in the history
  • Loading branch information
jmtavares committed Nov 12, 2018
1 parent f782b61 commit 3c2fec6
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ These tags are only populated if available.
|:---|:---|
| browser | browser name |
| browser_version | browser version |
| device | device type (desktop, tablet or mobile)|
| device_type | device type (desktop, tablet or mobile)|
| os | os name|
| os_version | os version|

Expand Down
4 changes: 2 additions & 2 deletions dist/statful-browser-plugin.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/statful-browser-plugin.umd.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "statful-browser-plugin",
"version": "1.0.1",
"version": "1.0.2",
"description": "Statful Browser Plugin",
"main": "dist/statful-browser-plugin.min.js",
"browser": "dist/statful-browser-plugin.umd.min.js",
Expand Down
2 changes: 1 addition & 1 deletion src/statful-browser-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class StatfulBrowserPlugin {
}

if (result.platform) {
this.tags.device = result.platform.type;
this.tags.device_type = result.platform.type;
}

if (result.os) {
Expand Down
6 changes: 3 additions & 3 deletions tests/statful-browser-plugin.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('Statful Browser Plugin', () => {
expect(instance.tags).toEqual({
browser: 'Chrome',
browser_version: '69.1.2',
device: 'desktop',
device_type: 'desktop',
os: 'os',
os_version: '2.0.0'
});
Expand Down Expand Up @@ -86,7 +86,7 @@ describe('Statful Browser Plugin', () => {
expect(instance.name).toEqual('statful-browser-plugin');
expect(instance.version).toEqual('1.0.0');
expect(instance.tags).toEqual({
device: 'desktop',
device_type: 'desktop',
os: 'os',
os_version: '2.0.0'
});
Expand Down Expand Up @@ -146,7 +146,7 @@ describe('Statful Browser Plugin', () => {
expect(instance.tags).toEqual({
browser: 'Chrome',
browser_version: '69.1.2',
device: 'desktop'
device_type: 'desktop'
});
});
});

0 comments on commit 3c2fec6

Please sign in to comment.