Skip to content

test(go): increase timeouts to make tests less fragile in GH workflows#32

Merged
padlar merged 2 commits intostatnett:mainfrom
padlar:increase-timeout-test
Jan 11, 2023
Merged

test(go): increase timeouts to make tests less fragile in GH workflows#32
padlar merged 2 commits intostatnett:mainfrom
padlar:increase-timeout-test

Conversation

@padlar
Copy link
Copy Markdown
Contributor

@padlar padlar commented Jan 11, 2023

Closes #27.

Signed-off-by: Sunil Shivanand padlar@live.com

Signed-off-by: Sunil Shivanand <padlar@live.com>
@padlar padlar requested a review from a team as a code owner January 11, 2023 13:29
Copy link
Copy Markdown
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but maybe adjust the title? Suggestion:
test(go): increase timeouts to make tests less fragile in GH workflows

And maybe this closes #27?

@padlar padlar changed the title chore(test): increase the timeout if the tests pass in github test(go): increase timeouts to make tests less fragile in GH workflows Jan 11, 2023
@padlar padlar requested a review from erikgb January 11, 2023 14:26
Copy link
Copy Markdown
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we assume it closes #27? We can just reopen it if it doesn't.

@padlar
Copy link
Copy Markdown
Contributor Author

padlar commented Jan 11, 2023

Updated

@padlar padlar merged commit d3f3d9b into statnett:main Jan 11, 2023
@padlar padlar deleted the increase-timeout-test branch January 11, 2023 14:32
@erikgb erikgb mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go tests seem flaky

2 participants