Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): reconfigure collectors for flaky e2e-test #95

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

erikgb
Copy link
Member

@erikgb erikgb commented Jan 19, 2023

This reconfigures the collectors for the flaky e2e-test, ref. #19. Trying to get as much info as possible from assumed relevant stuff.

@erikgb erikgb requested a review from a team as a code owner January 19, 2023 09:12
bendikp
bendikp previously approved these changes Jan 19, 2023
Copy link
Member

@bendikp bendikp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikgb erikgb enabled auto-merge (squash) January 19, 2023 09:16
@erikgb erikgb force-pushed the improve-vuln-test-collectors branch from 2e55543 to 00fa15d Compare January 19, 2023 10:44
@erikgb erikgb disabled auto-merge January 19, 2023 11:29
@erikgb erikgb force-pushed the improve-vuln-test-collectors branch from 1b91ef6 to d686d73 Compare January 19, 2023 11:31
@erikgb erikgb force-pushed the improve-vuln-test-collectors branch from 673cdd2 to 49d76db Compare January 19, 2023 11:56
@erikgb erikgb requested a review from bendikp January 19, 2023 11:57
@erikgb
Copy link
Member Author

erikgb commented Jan 19, 2023

Shell/script syntax like > does not seem to work for collector commands. Going for a standard pod-collector.

@erikgb erikgb enabled auto-merge (squash) January 19, 2023 11:57
Co-authored-by: Bendik Paulsrud <bendik.paulsrud@gmail.com>
Copy link
Member

@bendikp bendikp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikgb erikgb merged commit 8074c45 into statnett:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants