feat: ability to bless (not terminate) topics by name/regex #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
blessed-topics
branch
from
b57ea2d
to
a472611
Compare
sverrehu
reviewed
Oct 21, 2024
src/main/java/io/statnett/k3a/topicterminator/ApplicationProperties.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sverre H. Huseby <shh+github@thathost.com>
sverrehu
reviewed
Oct 21, 2024
sverrehu
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some topics in our cluster without data or consumers that is somehow still in use. This new feature will allow us to configure those topics to retain - even if they are marked for deletion by the standard rules.