Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset ignorePaths to default #26

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mikaelol
Copy link
Contributor

@mikaelol mikaelol commented Nov 4, 2024

We are extending config:base (which, by the way, should be migrated to config:recommended) in this project, and that preset includes :ignoreModulesAndTests, defined as:

{
  "ignorePaths": [
    "**/node_modules/**",
    "**/bower_components/**",
    "**/vendor/**",
    "**/examples/**",
    "**/__tests__/**",
    "**/test/**",
    "**/tests/**",
    "**/__fixtures__/**"
  ],
  "nuget": {
    "ignorePaths": [
      "**/node_modules/**",
      "**/bower_components/**",
      "**/vendor/**",
      "**/examples/**",
      "**/__fixtures__/**"
    ]
  }
}

In downstream projects, we have dependencies in our test folders, e.g., test/e2e-config/k3d-config.yml, and those are being ignored.

The suggested fix is to override ignorePaths to the Renovate default: ["**/node_modules/**", "**/bower_components/**"].

@mikaelol mikaelol merged commit 99c25c9 into statnett:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants