fix chronos v4 compatiblity #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yield` has never worked correctly in chronos - removing broken function. Also, the "official" way of checking the state of the future is via `failed`
arnetheduck
added a commit
that referenced
this pull request
Nov 17, 2023
* update readme * Don't log non-printable characters * bump mingw from v8.1.0 to v11.2.0 * ci: reenable windows matrix * CI: test with multiple Nim versions (#106) * CI: test with multiple Nim versions - plus Nim-1.6 fix - and enable Windows * size.nim: halve the number of log lines * enable styleCheck:usages (nbc branch) (#113) * fix chronos v4 compatiblity (#138) `yield` has never worked correctly in chronos - removing broken function. Also, the "official" way of checking the state of the future is via `failed` --------- Co-authored-by: Zahary Karadjov <zahary@gmail.com> Co-authored-by: jangko <jangko128@gmail.com> Co-authored-by: Ștefan Talpalaru <stefantalpalaru@yahoo.com> Co-authored-by: Etan Kissling <etan@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yieldhas never worked correctly in chronos - removing broken function.Also, the "official" way of checking the state of the future is via
failed