Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ImplicitTemplateRedefinition warning #153

Closed
wants to merge 3 commits into from
Closed

fix ImplicitTemplateRedefinition warning #153

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d75a5cb
fix ImplicitTemplateRedefinition warning
tersec Sep 10, 2024
1479ae0
retain Nim 1.6 compatibility
tersec Sep 10, 2024
d357e28
Update chronicles.nim
tersec Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions chronicles.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,16 @@ macro logScopeIMPL(prevScopes: typed,
result.add chroniclesExportNode

let activeScope = id("activeChroniclesScope", isPublic)
result.add quote do:
template `activeScope` {.redefine, used.} =
`newRevision`
`newAssingments`
when NimMajor >= 2:
tersec marked this conversation as resolved.
Show resolved Hide resolved
result.add quote do:
template `activeScope` {.redefine, used.} =
`newRevision`
`newAssingments`
else:
result.add quote do:
template `activeScope` {.used.} =
`newRevision`
`newAssingments`

template logScope*(newBindings: untyped) {.dirty.} =
bind bindSym, logScopeIMPL, brForceOpen
Expand Down