Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of PRESTO middleware. #73

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add implementation of PRESTO middleware. #73

merged 3 commits into from
Feb 21, 2024

Conversation

cheatfate
Copy link
Collaborator

No description provided.

arnetheduck
arnetheduck reviewed Jan 22, 2024
View reviewed changes
presto/middleware.nim Outdated Show resolved Hide resolved
@chair28980 chair28980 mentioned this pull request Jan 22, 2024
Closed
NagyZoltanPeter
NagyZoltanPeter approved these changes Feb 18, 2024
View reviewed changes
Copy link

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I have finished (after couple of downprio) CORS implementation of nim-waku using this PR. It is working.
I will need to PR to be merged and released to finalize my PR on nwaku.

Thank you.

@cheatfate cheatfate merged commit 223aade into master Feb 21, 2024
12 checks passed
@cheatfate cheatfate deleted the presto-middleware branch February 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck arnetheduck left review comments

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheatfate @arnetheduck @NagyZoltanPeter