Remove error field from AccessListResult #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangko
force-pushed
the
fix-get-accesslist-response
branch
from
90744d1
to
75eed5e
Compare
The test is already included in previous commit of test_execution_api fix. I separate the commit to let users of this library aware of this changes. This changes is also needed in eth hive test of rpc compat simulator.
jangko
force-pushed
the
fix-get-accesslist-response
branch
from
75eed5e
to
7470012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
errorfield ofAccesListResultis not documented anywhere, probably a mistake when it first introduced in nim-web3. And the execution_api test not detecting this because of a bug in nim-json-serializationJsonValueRef.Objectcomparison.status-im/nim-json-serialization#88