Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AuthorizationObject fields name to v, r, s #172

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix AuthorizationObject fields name to v, r, s #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e9243
Fix AuthorizationObject fields name to v, r, s
jangko Oct 15, 2024
83284ea
Fix identifier style error
jangko Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_execution_types.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ suite "Execution types tests":
)

blobs = BlobsBundleV1(
commitments: @[KZGCommitment.conv(1)],
proofs: @[KZGProof.conv(2)],
commitments: @[KzgCommitment.conv(1)],
proofs: @[KzgProof.conv(2)],
blobs: @[Blob.conv(3)],
)

Expand Down
4 changes: 2 additions & 2 deletions web3/engine_api_types.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ type

# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/cancun.md#blobsbundlev1
BlobsBundleV1* = object
commitments*: seq[KZGCommitment]
proofs*: seq[KZGProof]
commitments*: seq[KzgCommitment]
proofs*: seq[KzgProof]
blobs*: seq[Blob]

# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/shanghai.md#executionpayloadbodyv1
Expand Down
14 changes: 7 additions & 7 deletions web3/eth_api_types.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ type

# EIP-4844 blob sidecars
blobs*: Opt[seq[Blob]]
commitments*: Opt[seq[KZGCommitment]]
proofs*: Opt[seq[KZGProof]]
commitments*: Opt[seq[KzgCommitment]]
proofs*: Opt[seq[KzgProof]]

# EIP-7702
authorizationList*: Opt[seq[AuthorizationObject]]
Expand Down Expand Up @@ -149,9 +149,9 @@ type
chainId*: Quantity
address*: Address
nonce*: Quantity
yParity*: Quantity
R*: UInt256
S*: UInt256
v*: Quantity
r*: UInt256
s*: UInt256

TransactionObject* = ref object # A transaction object, or null when no transaction was found:
hash*: Hash32 # hash of the transaction.
Expand All @@ -171,7 +171,7 @@ type
yParity*: Opt[Quantity] # ECDSA y parity, none for Legacy, same as v for >= Tx2930
`type`*: Opt[Quantity] # EIP-2718, with 0x0 for Legacy
chainId*: Opt[Quantity] # EIP-159
accessList*: Opt[seq[AccessPair]] # EIP-2930
accessList*: Opt[seq[AccessPair]] # EIP-2930
maxFeePerGas*: Opt[Quantity] # EIP-1559
maxPriorityFeePerGas*: Opt[Quantity] # EIP-1559
maxFeePerBlobGas*: Opt[UInt256] # EIP-4844
Expand All @@ -181,7 +181,7 @@ type
ReceiptObject* = ref object # A transaction receipt object, or null when no receipt was found:
transactionHash*: Hash32 # hash of the transaction.
transactionIndex*: Quantity # integer of the transactions index position in the block.
blockHash*: Hash32 # hash of the block where this transaction was in.
blockHash*: Hash32 # hash of the block where this transaction was in.
blockNumber*: Quantity # block number where this transaction was in.
`from`*: Address # address of the sender.
to*: Opt[Address] # address of the receiver. null when its a contract creation transaction.
Expand Down
Loading