REST: Add implementation of postStateValidators and postStateValidatorBalances. #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validators and /eth/v1/beacon/states/{state_id}/validator_balances.
Add tests.
tersec
reviewed
Nov 28, 2023
tersec
reviewed
Nov 28, 2023
Fix toList() issue.
tersec
reviewed
Nov 28, 2023
tersec
reviewed
Nov 28, 2023
tersec
reviewed
Nov 28, 2023
tersec
reviewed
Nov 28, 2023
tersec
reviewed
Nov 28, 2023
cheatfate
commented
Nov 28, 2023
| for item in statuses.get(): | ||
| let value = decodeString(ValidatorFilter, item).valueOr: | ||
| reader.raiseUnexpectedValue($error) | ||
| if value * res != {}: |
There was a problem hiding this comment.
They are not identical but they are not unique, according to specification values should be unique, so there should be no intersection.
https://github.com/ethereum/beacon-APIs/pull/367/files#diff-cc9071f40d45ee8fad4e7513c3351001c1445d206d6726c65a0000421110b1c3R122
Fix unique check for validator identifiers.
tersec
reviewed
Nov 29, 2023
tersec
reviewed
Nov 29, 2023
tersec
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ethereum/beacon-APIs#367 and tests.