fix: selecting Aragon token for permission creation fails the process #19602
+56
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins Builds
|
saledjenic
force-pushed
the
fix/payment-request
branch
from
f623142 to
f05b508
Compare
saledjenic
force-pushed
the
fix/issue-19597
branch
from
0f814ac to
fc612d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the assets list contains tokens of interests (since introduction of a new tokens approach, due to performance reasons) and since Aragon was not there we should fetch it from the backend (statusgo).
These changes require some changes (
getTokenByKeyOrGroupKeyFromAllTokens) done in the payment requests fix, that's why that branch was used as a base.Fixes #19597
AragonPermission.mov