Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs in utc time #16373

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: logs in utc time #16373

merged 2 commits into from
Sep 20, 2024

Conversation

igor-sirotin
Copy link
Contributor

What does the PR do

Closes #15198

Screenshot of functionality (including design for comparison)

Screenshot 2024-09-20 at 15 52 02

Impact on end user

Less identity disclusure.

How to test

Start app
Check logs are in UTC time and not in local time

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@igor-sirotin igor-sirotin requested review from jrainville and a team September 20, 2024 14:57
@igor-sirotin igor-sirotin self-assigned this Sep 20, 2024
@igor-sirotin igor-sirotin requested review from iurimatias and removed request for a team September 20, 2024 14:57
@igor-sirotin
Copy link
Contributor Author

kudos to @Ivansete-status ❤️

@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f5d24b4 #1 2024-09-20 15:04:37 ~6 min tests/nim 📄log
✔️ f5d24b4 #1 2024-09-20 15:05:07 ~7 min macos/aarch64 🍎dmg
f5d24b4 #1 2024-09-20 15:09:16 ~11 min tests/ui 📄log
✔️ f5d24b4 #1 2024-09-20 15:13:12 ~15 min macos/x86_64 🍎dmg
✔️ f5d24b4 #1 2024-09-20 15:14:47 ~16 min linux-nix/x86_64 📦tgz
✔️ f5d24b4 #1 2024-09-20 15:15:39 ~17 min linux/x86_64 📦tgz
✔️ f5d24b4 #1 2024-09-20 15:19:10 ~21 min windows/x86_64 💿exe
✔️ f5d24b4 #2 2024-09-20 17:23:27 ~12 min tests/ui 📄log

@igor-sirotin igor-sirotin merged commit a745f09 into master Sep 20, 2024
9 checks passed
@igor-sirotin igor-sirotin deleted the fix/15198-logs-utc branch September 20, 2024 18:50
iurimatias pushed a commit that referenced this pull request Sep 24, 2024
* chore_: update nim-chronicles

* fix: chronicles_timestamps RfcUtcTime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs in UTC time
4 participants