Skip to content

Commit

Permalink
Various improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
staudenmeir committed Sep 17, 2023
1 parent 6d828be commit 018b36d
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 11 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
name: CI

on: [push, pull_request]
on: [ push, pull_request ]

jobs:
tests:
runs-on: ubuntu-latest

strategy:
matrix:
php: [8.1, 8.0, 7.4, 7.3]
release: [stable, lowest]
php: [ 8.1, 8.0, 7.4, 7.3 ]
release: [ stable, lowest ]
include:
- php: 7.4
release: stable
coverage: xdebug

steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/checkout@v3
- uses: actions/cache@v3
with:
path: ~/.composer/cache/files
key: php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/.idea
/vendor
.php-cs-fixer.cache
.phpunit.result.cache
composer.lock
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
![CI](https://github.com/staudenmeir/dusk-updater/workflows/CI/badge.svg)
# Dusk Updater

[![CI](https://github.com/staudenmeir/dusk-updater/actions/workflows/ci.yml/badge.svg)](https://github.com/staudenmeir/dusk-updater/actions/workflows/ci.yml)
[![Code Coverage](https://scrutinizer-ci.com/g/staudenmeir/dusk-updater/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/staudenmeir/dusk-updater/?branch=master)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/staudenmeir/dusk-updater/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/staudenmeir/dusk-updater/?branch=master)
[![Latest Stable Version](https://poser.pugx.org/staudenmeir/dusk-updater/v/stable)](https://packagist.org/packages/staudenmeir/dusk-updater)
[![Total Downloads](https://poser.pugx.org/staudenmeir/dusk-updater/downloads)](https://packagist.org/packages/staudenmeir/dusk-updater)
[![License](https://poser.pugx.org/staudenmeir/dusk-updater/license)](https://packagist.org/packages/staudenmeir/dusk-updater)

## Introduction
[![Total Downloads](https://poser.pugx.org/staudenmeir/dusk-updater/downloads)](https://packagist.org/packages/staudenmeir/dusk-updater/stats)
[![License](https://poser.pugx.org/staudenmeir/dusk-updater/license)](https://github.com/staudenmeir/dusk-updater/blob/master/LICENSE)

This Artisan command updates your Laravel Dusk ChromeDriver binaries to the latest or specified release.

Expand Down
2 changes: 2 additions & 0 deletions src/UpdateCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class UpdateCommand extends Command
public static $extensions = [
'linux' => '',
'mac' => '',
'mac-intel' => '',
'mac-arm' => '',
'win' => '.exe',
];

Expand Down
2 changes: 1 addition & 1 deletion tests/UpdateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ protected function driverVersion($major = null)
}

if ($major < 115) {
$url = 'https://chromedriver.storage.googleapis.com/LATEST_RELEASE'.'_'.$major;
$url = "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_$major";

return trim((string) file_get_contents($url));
}
Expand Down

0 comments on commit 018b36d

Please sign in to comment.