Draft: refactor(server-request-manager): fix build errors and major refactors

[DarkPhoenix42]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors the server request manager to fix build errors and update the code to use the new IClientHandler interface and revised ClientInfo handling. Key changes include:

• Replacing the old ClientHandler class with the IClientHandler interface.
• Updating test functions (e.g., connect_test_client) to return a tuple with a success flag.
• Adjusting ConnectionManager and request manager implementations to use the new client information model.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/unittests/server/server_connection_manager_test.cpp	Updated test signatures and assertions to match the new ClientInfo tuple.
src/server/connection_manager.cpp	Modified client handling and request processing using the new interface.
src/server/client_info.cpp	Introduced the ClientInfo and FileSystemTree implementation.
include/server/request_manager.hpp	Revised the ClientHandler interface and added client_info dependency.
include/server/connection_manager.hpp	Updated to utilize IClientHandler instead of the old ClientHandler.
include/server/client_info.hpp	Added definitions for ClientInfo and FileSystemTree.

Files not reviewed (1)

• src/server/CMakeLists.txt: Language not supported

[Copilot]

Consider adding or updating documentation for connect_test_client() to clarify its new return type, including the success flag, for better clarity in test behavior.

Suggested change

	/**
	* Establishes a test client connection to the server.
	*
	* @return A pair containing:
	* - ClientInfo: Information about the connected client, including
	* its socket, encryption key, address, and port.
	* - bool: A success flag indicating whether the connection and
	* key exchange were successful (true) or not (false).
	*/

[v1bh475u]

This function is not defined anywhere. Please look into it.

[v1bh475u]

Is there any need for declaring a custom constructor without a custom destructor? The constructor is not defined. Maybe you wanted to call initialize_file_system_tree inside the constructor.

[v1bh475u]

closing this as already done in #64