WIP: Implement Uyuni support #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstracted hosts
This reverts commit 480e5e6.
okin
requested changes
May 11, 2021
There was a problem hiding this comment.
I think you can also add support for Uyuni in README.md :)
What are the multiple requirements files (requirements_uyuni.yml & requirements_uyuniclient.yml) for?
I think the next step would be that ForemanAPIClient and UyuniApiClient provide the same interface to any caller. Work in this regard seems to have been done for Uyuni already but is missing for Foreman.
If we are tackling this I'd suggest also making use of our abstract host class for this. This should allow us to have all IDs belonging to one client in different systems in one object in our codebase.
In the modules that provide a CLI interface only ForemanAPIClient is instantiated.
Once there is a common interface these occurances should be replaced by using the factory katprep.management.get_management_client.
…tprep into 43-feat-uyuni_support
Remove unused mocking modules
Strip leading and trailing whitespace from credentials
Handle different date formats
* add pre/post script parameters * update documentation * update manpages * update documentation * fix linting * add call for getting host custom info keys * add API calls and tests for custom variables * update docstrings * add calls/tests for managing host custom values * added call/tests for running host commands * fix typo * add calls/tests for action chains * use similiar variable names * add properties to retrieve pre/post scripts * add abstract methods for pre/post scripts * implement optional pre/post script handling * fix linting * fix parameter names * run action chain for patches/upgrades * fix missing returns for action chains * fix pre/post script property * add missing parameters for patches/upgrades * fix host references * add action chain tests * add call/test for getting script task info * print still running jobs * include script execution tasks * show message if errata already installed * fix incorrect errata ID format and missing script hints * print action type instead of long description * fix broken script task counter * fix incorrect hostname parameter * use safe full YAML loader * fix linting * add URLs for Uyuni 2022.01 and 2022.02 * add hint about PATH variable during installation * add note about Python dependencies * update documentation * make finding hosts modular * ensure that VMs without IP won't crash search * Refactor handling of pre- and post-scripts This allows running pre and post independent from each other and also if only one of them is set. * added Uyuni 2022.03 links * add new post/pre script parameters used for setting effective user/group * update documentation * add pre/post script user/group properties * run pre/post script with appropriate user * add host filter calls * add calls for getting hostname by ID * remove Python 2 support * add missing Uyuni support to parameters.py * fix linting * remove unneeded filter references * update tested products * add Uyuni 2022.04 links * update Python installation notes * add Uyuni user preparation * bump documentation * update/order parameter documentation * bump documentation release * updated changelog * bump documentation version * formatted hint about breaking changes in 0.6.0 * bump box and Ansible role versions * drop Nagios sites as it's supported by OMD anymore * fix typo * add fix for Vagrantbox * bump Uyuni version * bump documentation * rename pre/post script parameters We're also going to implement reboot pre/post scripts * update documentation * add reboot pre/post script parameters * update documentation * bump documentation * add reboot pre/post scripts * update documentation * bump documentation Co-authored-by: Niko Wenselowski <niko.wenselowski@sva.de>
…into okin-43-patch_filtering
otherwise reboots will intefere with patching
okin
requested changes
Jun 6, 2022
| self.actionchain_add_upgrades(chain_label, system_id, upgrades) | ||
| ) | ||
| except EmptySetException as err: | ||
| if err == "No upgrades defined": |
There was a problem hiding this comment.
This will not work. You have to use access the attribute containing the message for the comparison otherwise this will never be true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also issue #43