Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to graph namespace #130

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Move to graph namespace #130

merged 5 commits into from
Sep 2, 2024

Conversation

pratzl
Copy link
Collaborator

@pratzl pratzl commented Sep 2, 2024

Move from std::graph --> graph namespace for general use

Add skeletons for bfs, dfs & topological sort algos for training others

…e number of vertices

Added concept constraint to require distances and predecessors to be sized_range

Use iota to initialize predecessors
Bellman-Ford algorithms now return optional<vertex_id_t<G>>
This makes it usable as a stand-alone library without the pretension it will make it into the standard

Add graph_using.hpp to explicitly bring common types & functions into the graph namespace
These will be used for training.
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 83.55263% with 50 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (a5dabdc) to head (3f0ac1b).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
example/CppCon2021/examples/ospf.cpp 0.00% 10 Missing ⚠️
...de/graph/algorithm/bellman_ford_shortest_paths.hpp 61.11% 7 Missing ⚠️
...nclude/graph/algorithm/dijkstra_shortest_paths.hpp 50.00% 7 Missing ⚠️
example/CppCon2021/examples/graphs.cpp 0.00% 4 Missing ⚠️
include/graph/container/dynamic_graph.hpp 55.55% 4 Missing ⚠️
example/CppCon2021/include/utilities.hpp 0.00% 3 Missing ⚠️
tests/bellman_shortest_paths_tests.cpp 70.00% 3 Missing ⚠️
example/CppCon2021/examples/imdb.cpp 0.00% 2 Missing ⚠️
.../graph/algorithm/experimental/visitor_dijkstra.hpp 33.33% 2 Missing ⚠️
include/graph/container/compressed_graph.hpp 88.88% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   91.67%   91.51%   -0.16%     
==========================================
  Files          58       61       +3     
  Lines        4636     4658      +22     
  Branches      402      405       +3     
==========================================
+ Hits         4250     4263      +13     
- Misses        386      395       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pratzl pratzl merged commit 300bd9b into master Sep 2, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant