Changes from feedback #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include graph_using.hpp to avoid error
One ctor accepted an allocator, the other didn't Replaced VKR template parameter with Seeds for clarity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 61 61
Lines 4637 4637
Branches 406 406
=======================================
Hits 4242 4242
Misses 395 395 ☔ View full report in Codecov by Sentry. |
There are a few similar definitions that are defined internally in both gcc and mscvc that we need for the graph-v2 implementation. An issue was reported that they weren't defined when using MSVC, so I've renamed the defintions to be unique across the compilers to always use our own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.