Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El rng #88

Merged
merged 2 commits into from
Jan 20, 2024
Merged

El rng #88

merged 2 commits into from
Jan 20, 2024

Conversation

pratzl
Copy link
Collaborator

@pratzl pratzl commented Jan 20, 2024

Bacon example in paper now works

The issue appears to be name lookup when target_id is used in vertexlist
I think it has to do with target_id is defined in a different namespace than std, where vertex is defined

Refactored target_id, target and vertexlist:
Remove unnecessary _UnCV
Replace _G& wtih _G in template arguments
Requiring target_id(g,uv) required defining it in std namespace
It would also need to be defined in the boost::container namespace if boost containers used
This is invasive enough, with a useful use case, that it's worth providing default impl

Tests using Kevin Bacon
vector<vector<int>>
vector<vector<tuple<int>>>
@pratzl pratzl merged commit 8fa358b into master Jan 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant