Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.6.0] Add stop and extract #149

Merged
merged 2 commits into from
May 1, 2018
Merged

[v0.6.0] Add stop and extract #149

merged 2 commits into from
May 1, 2018

Conversation

sakuraehikaru
Copy link

See #119 for more information.

@larryonoff and @DrAma999 It would be great to get your feedback and review as well. Thanks!

@sakuraehikaru sakuraehikaru self-assigned this Apr 9, 2018
@sakuraehikaru sakuraehikaru requested a review from nbrooke April 9, 2018 23:01
Copy link
Member

@nbrooke nbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sakuraehikaru sakuraehikaru merged commit 779531f into master May 1, 2018
@sakuraehikaru sakuraehikaru deleted the add-stop-and-extract branch May 1, 2018 21:00
@larryonoff
Copy link
Contributor

Sorry for not responding so long. This PR looks god for my. But I think that Bluejay should has a way of checking the current state: started / stopped. BTW this's the feature that was needed not only as a part of this PR.

@sakuraehikaru
Copy link
Author

No worries. Yes I agree we should have a way of checking that. I will add that to 0.6.3 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants