Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SRTP double-encryption on send #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix SRTP double-encryption on send #2

wants to merge 1 commit into from

Commits on Nov 5, 2024

  1. Fix SRTP double-encryption on send 

    It turns out that the SRTP send implementation was redundantly encrypting payloads when using the
4-ary `sendPacket` method. The override for that method in `SRTPProtocolImpl` would encrypt the
payload data and then proceed to invoke its parent's implementation. That one in turn would invoke
the 5-ary `sendPacket` method which is also overriden in `SRTPProtocolImpl`. That override would
encrypt the payload a second time, resulting in garbled data on the receiver's end.

Fixed by removing the 4-ary override from `SRTPProtocolImpl`.
    @DerGuteMoritz
    DerGuteMoritz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    66d319b View commit details
    Browse the repository at this point in the history