Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flake.nix and ipkg-parser.nix #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

srghma
Copy link

@srghma srghma commented Oct 20, 2024

followup of #311

I have added nix builer for all 3 packages

…tical output to idris2 --dump-ipkg-json ./mypackage.ipkg, but implemented in pure nix
@stefan-hoeck
Copy link
Owner

Thanks for doing this. Please note that I'm not a nix user and will not be able to maintain this. I'm therefore wondering if this truly needs to be part of the pack repo or if this would not be better off in its own repo with a link from pack's documentation.

If this is going to stay in the pack repo itself, it will need some documentation in the installation guide plus some CI tests to make sure it works correctly.

@srghma
Copy link
Author

srghma commented Oct 20, 2024

I'm not a nix user

yes, I know

link from pack's documentation

wow, thats generous, idris community is different, other people would just close)

it will need some documentation in the installation guide plus some CI tests

can do

@stefan-hoeck
Copy link
Owner

In that case I'd suggest to keep this as part of the pack repo for the time being as long as we have proper CI tests and documentation. If the CI starts to fail and no one is around to maintain this, I'll be forced to remove it, but I'd like to have documented nix support for pack.

@stefan-hoeck
Copy link
Owner

What is the status of this PR? I'm all for merging but not without proper CI tests and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants