Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detector implementation #18

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Add detector implementation #18

merged 11 commits into from
Sep 24, 2024

Conversation

stefanDeveloper
Copy link
Owner

Solves #14 and #12

Currently, this is a first draft to init the basic implementation. Later, when our models are trained, adaptions have to be made.

@stefanDeveloper stefanDeveloper self-assigned this Sep 23, 2024
@stefanDeveloper stefanDeveloper added the enhancement New feature or request label Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1313 976 74% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/_init_.py 100% 🟢
src/base/kafka_handler.py 63% 🟢
src/detector/detector.py 94% 🟢
TOTAL 86% 🟢

updated for commit: e85a862 by action🐍

src/detector/detector.py Outdated Show resolved Hide resolved
src/detector/detector.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two little changes in the logging messages, other than that it looks great.

@stefanDeveloper
Copy link
Owner Author

Just two little changes in the logging messages, other than that it looks great.

Fixed!

@stefanDeveloper stefanDeveloper merged commit 6764c59 into main Sep 24, 2024
12 checks passed
@stefanDeveloper stefanDeveloper linked an issue Sep 25, 2024 that may be closed by this pull request
@lamr02n lamr02n deleted the add-detector branch October 7, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add detector implementation
2 participants