Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPv6 #44

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Add support for IPv6 #44

merged 4 commits into from
Oct 15, 2024

Conversation

lamr02n
Copy link
Collaborator

@lamr02n lamr02n commented Oct 13, 2024

The subnet ID is now calculated for IPv4 or IPv6 addresses. It still works as before and cuts off the address after the prefix. As before, e.g. _64 (for prefix_length = 64) is added. Resolves #5.

@lamr02n lamr02n added the enhancement New feature or request label Oct 13, 2024
@lamr02n lamr02n self-assigned this Oct 13, 2024
Copy link

github-actions bot commented Oct 13, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1185 1079 91% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/utils.py 100% 🟢
src/logcollector/collector.py 100% 🟢
TOTAL 100% 🟢

updated for commit: ae8fdc3 by action🐍

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (b285b1f) to head (ae8fdc3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   90.30%   90.37%   +0.07%     
==========================================
  Files          11       11              
  Lines        1176     1185       +9     
  Branches      150      118      -32     
==========================================
+ Hits         1062     1071       +9     
  Misses        106      106              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamr02n lamr02n merged commit 80b3b85 into main Oct 15, 2024
17 checks passed
@lamr02n lamr02n deleted the support-ipv6 branch October 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IPv6
2 participants