Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server receiving with separator #49

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

lamr02n
Copy link
Collaborator

@lamr02n lamr02n commented Nov 3, 2024

When sending many log lines almost simultaneously to the LogServer, they were received as one message and therefore invalid. Now messages sent need to be separated by \n.

@lamr02n lamr02n self-assigned this Nov 3, 2024
@lamr02n lamr02n added the bug Something isn't working label Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1195 1089 91% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/logserver/server.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 712ae01 by action🐍

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (0a7fc7e) to head (712ae01).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   90.37%   90.46%   +0.08%     
==========================================
  Files          11       11              
  Lines        1185     1195      +10     
  Branches      118      118              
==========================================
+ Hits         1071     1081      +10     
  Misses        106      106              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lamr02n lamr02n mentioned this pull request Nov 4, 2024
Copy link
Owner

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@stefanDeveloper stefanDeveloper merged commit b7d6ca4 into main Nov 5, 2024
17 checks passed
@stefanDeveloper stefanDeveloper deleted the fix-server-receiving-with-separator branch November 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants