Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django and Python supported versions #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pfouque
Copy link

@pfouque pfouque commented Jan 28, 2024

Hi,

Looking for an SMS sending solution, I noticed the project was a bit outdated, so I built this PR to catch up.

  • Add support for django 4.1, 4.2, and django 5.0
  • Add support for Python 3.10, 3.11, and 3.12
  • Remove support for django 2.2 and 3.0
  • Remove support for Python 3.6, 3.7
  • Remove remaining pieces of Python 2 support

Thanks

test.py Outdated
Comment on lines 207 to 203
# with self.assertRaisesRegex(RuntimeError, "Invalid smsAccount"):
with self.assertRaises(RuntimeError):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It raises a 429 instead ...

@@ -21,10 +23,12 @@ commands =
coverage report
deps =
coverage
dj22: Django~=2.2.0
dj30: Django~=3.0.0
setuptools
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, the one installed by the CI wasn't available...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant