-
-
Notifications
You must be signed in to change notification settings - Fork 2
Adds options to customize notifications #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to have custom notification messages, we need to ensure these are available for all of the notifications, as currently this does not cover the print_minutes_until
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go now
This adds the options `msg_hydrate_now`, `msg_hydrated`, `msg_minutes_until`, which can be used to customize the corresponding popup text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good and I'll merge this in once this change is made, thanks again for the PR and sorry about turnaround time, been extremely busy!
This is now available in |
This PR introduces the possibility to reword the reminder and
:HydrateNow
acknowledgement.