Skip to content

Adds options to customize notifications #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

mormod
Copy link
Contributor

@mormod mormod commented Mar 10, 2024

This PR introduces the possibility to reword the reminder and :HydrateNow acknowledgement.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to have custom notification messages, we need to ensure these are available for all of the notifications, as currently this does not cover the print_minutes_until function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now

Moritz Reinhard Hüllmann added 3 commits May 14, 2024 23:12
This adds the options `msg_hydrate_now`, `msg_hydrated`,
`msg_minutes_until`, which can be used to customize the corresponding
popup text.
Copy link
Owner

@stefanlogue stefanlogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good and I'll merge this in once this change is made, thanks again for the PR and sorry about turnaround time, been extremely busy!

@stefanlogue stefanlogue merged commit edd7148 into stefanlogue:main Jul 11, 2024
2 of 4 checks passed
@stefanlogue
Copy link
Owner

This is now available in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants