Skip to content

fix(timeline): HI dependency arrows missing on Gantt chart#572

Merged
steilerDev merged 2 commits intobetafrom
fix/571-hi-dep-arrows
Mar 8, 2026
Merged

fix(timeline): HI dependency arrows missing on Gantt chart#572
steilerDev merged 2 commits intobetafrom
fix/571-hi-dep-arrows

Conversation

@steilerDev
Copy link
Owner

Summary

  • Include targetDeliveryDate in the HI positioning fallback chain so household items with scheduler-computed dates appear on the Gantt chart and their dependency arrows render

Fixes #571

Test plan

  • Pre-commit hook quality gates pass
  • CI checks pass

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Copy link
Owner Author

@steilerDev steilerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[security-engineer] PR #572 — GanttChart HI date fallback

Single-line frontend change adding targetDeliveryDate to the date fallback chain for household item Gantt positioning. Reviewed for:

  • XSS: no new rendering of user-controlled HTML; the date string feeds SVG coordinate arithmetic only, not innerHTML or dangerouslySetInnerHTML.
  • Open redirect: not applicable (no navigation).
  • Sensitive data exposure: no new data fetched; all three date fields (actualDeliveryDate, targetDeliveryDate, earliestDeliveryDate) are already present in the existing TimelineResponse payload.
  • Input validation: the value is consumed by dateToX() coordinate math — an invalid/missing date triggers the existing if (!dateStr) continue guard.

No security issues identified.

Copy link
Owner Author

@steilerDev steilerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[product-architect]

Reviewed and no concerns. The one-line fix correctly adds targetDeliveryDate to the date fallback chain in the hiPoints computation, aligning it with GanttHouseholdItems.tsx (line 84) which already uses actualDeliveryDate ?? targetDeliveryDate. The scheduling engine writes computed dates to targetDeliveryDate, so omitting it caused HI dependency arrows to silently fail to render.

The extra earliestDeliveryDate tail in the fallback chain is a safe broader fallback that won't cause coordinate mismatches — if targetDeliveryDate is present, both the bar renderer and the arrow endpoint agree.

No schema, API contract, or architectural concerns. Would approve if this were not my own PR.

steilerDev pushed a commit that referenced this pull request Mar 8, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…w positions

The hiPoints memo used earliestDeliveryDate as fallback for positioning
HI dependency arrows. When the scheduling engine sets targetDeliveryDate
(via CPM), earliestDeliveryDate may be null, causing arrows to not render.
Add targetDeliveryDate to the fallback chain.

Fixes #571

Co-Authored-By: Claude frontend-developer (Haiku) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@steilerDev steilerDev force-pushed the fix/571-hi-dep-arrows branch from e879dc4 to 098e448 Compare March 8, 2026 00:37
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@steilerDev steilerDev merged commit 80c78c3 into beta Mar 8, 2026
13 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

🎉 This PR is included in version 1.13.0-beta.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants