fix(timeline): HI dependency arrows missing on Gantt chart#572
fix(timeline): HI dependency arrows missing on Gantt chart#572steilerDev merged 2 commits intobetafrom
Conversation
steilerDev
left a comment
There was a problem hiding this comment.
[security-engineer] PR #572 — GanttChart HI date fallback
Single-line frontend change adding targetDeliveryDate to the date fallback chain for household item Gantt positioning. Reviewed for:
- XSS: no new rendering of user-controlled HTML; the date string feeds SVG coordinate arithmetic only, not innerHTML or dangerouslySetInnerHTML.
- Open redirect: not applicable (no navigation).
- Sensitive data exposure: no new data fetched; all three date fields (
actualDeliveryDate,targetDeliveryDate,earliestDeliveryDate) are already present in the existingTimelineResponsepayload. - Input validation: the value is consumed by
dateToX()coordinate math — an invalid/missing date triggers the existingif (!dateStr) continueguard.
No security issues identified.
steilerDev
left a comment
There was a problem hiding this comment.
[product-architect]
Reviewed and no concerns. The one-line fix correctly adds targetDeliveryDate to the date fallback chain in the hiPoints computation, aligning it with GanttHouseholdItems.tsx (line 84) which already uses actualDeliveryDate ?? targetDeliveryDate. The scheduling engine writes computed dates to targetDeliveryDate, so omitting it caused HI dependency arrows to silently fail to render.
The extra earliestDeliveryDate tail in the fallback chain is a safe broader fallback that won't cause coordinate mismatches — if targetDeliveryDate is present, both the bar renderer and the arrow endpoint agree.
No schema, API contract, or architectural concerns. Would approve if this were not my own PR.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…w positions The hiPoints memo used earliestDeliveryDate as fallback for positioning HI dependency arrows. When the scheduling engine sets targetDeliveryDate (via CPM), earliestDeliveryDate may be null, causing arrows to not render. Add targetDeliveryDate to the fallback chain. Fixes #571 Co-Authored-By: Claude frontend-developer (Haiku) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e879dc4 to
098e448
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.13.0-beta.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
targetDeliveryDatein the HI positioning fallback chain so household items with scheduler-computed dates appear on the Gantt chart and their dependency arrows renderFixes #571
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com