fix(paperless): use AND logic for tag filtering#580
Merged
steilerDev merged 6 commits intobetafrom Mar 8, 2026
Merged
Conversation
Change tag filtering from OR logic (tags__id__in) to AND logic (tags__id__all) so documents must have ALL selected tags, not just any. Fixes #579. Co-Authored-By: Claude backend-developer (Haiku 4.5) <noreply@anthropic.com>
…d results When tags are selected with AND logic, display counts reflecting how many documents in the current filtered result set have that tag. This provides users meaningful feedback about tag combinations. Compute tagCountMap from returned documents (which already have tags field) and use it for chip counts in DocumentBrowser. Falls back to tag.documentCount when tagCountMap is empty. Fixes #579 Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
Add the missing tagCountMap property to the makeHook() fixture in the DocumentBrowser test file. This property was added to UsePaperlessResult in the tag intersection count feature but the test fixture wasn't updated. Co-Authored-By: Claude backend-developer (Haiku 4.5) <noreply@anthropic.com>
…tMap Update paperlessService tests to assert tags__id__all (AND semantics) instead of tags__id__in. Add usePaperless tests covering tagCountMap computation from returned document tags. Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) <noreply@anthropic.com> Co-Authored-By: Claude qa-integration-tester (Sonnet 4.5) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
steilerDev
commented
Mar 8, 2026
Owner
Author
steilerDev
left a comment
steilerDev
left a comment
There was a problem hiding this comment.
[security-engineer]
Security review for PR #580 — fix(paperless): use AND logic for tag filtering.
Scope: 3-line backend change (tags__id__in → tags__id__all) in paperlessService.ts + frontend tagCountMap computation in usePaperless.ts + DocumentBrowser.tsx display update + associated tests.
Findings: None.
Checklist:
- No injection vectors —
query.tagsis passed throughURLSearchParams.set(), which percent-encodes the value. The parameter key is a hardcoded string literal. No SSRF change; the base URL origin remains controlled by server-side env vars. - Auth/authorization unchanged — no new routes or middleware changes.
-
tagCountMapcomputation is pure client-side arithmetic over API-returned data; no user-controlled values reach any execution or rendering path. -
DocumentBrowser.tsxrenderscountas a JSX text node — nodangerouslySetInnerHTMLor string interpolation into HTML. ARIA label uses the same numeric value; React escapes attribute content. - No new dependencies introduced.
- No secrets or sensitive data exposure.
- Tests correctly assert
tags__id__allis present andtags__id__inis absent.
The fix is correct and the security posture is unchanged from the previous audit baseline.
steilerDev
commented
Mar 8, 2026
Owner
Author
steilerDev
left a comment
steilerDev
left a comment
There was a problem hiding this comment.
[product-architect]
Review complete — no architectural concerns. Would approve if not own PR.
Verified:
- Backend change correctly switches from
tags__id__in(OR) totags__id__all(AND) across all 3 code paths inpaperlessService.ts— matches Paperless-ngx API for AND tag semantics - Frontend
tagCountMapinusePaperlesshook provides intersection-aware counts with correct fallback totag.documentCount - No schema or API contract changes needed (this is a proxy query parameter fix)
- Test coverage adequate: unit tests for the parameter rename, new tests for
tagCountMapcomputation and edge cases - CI green (Quality Gates, Docker, tests all pass)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.13.0-beta.27 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tags__id__intotags__id__allinpaperlessService.tsso multi-tag filtering uses AND logic (documents must have ALL selected tags, not ANY)tagCountMaptousePaperlesshook — computes intersection-aware tag counts from the documents actually returned by the filtered query, so the tag count badges reflect the current filtered result setpaperlessService.test.tsto asserttags__id__allsemantics; addedusePaperless.test.tsxcoverage fortagCountMapcomputationFixes #579
Test plan