Skip to content

fix: isGroupHandle incorrectly returns false for group chats #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 2 commits into from
Feb 16, 2026
Merged

fix: isGroupHandle incorrectly returns false for group chats #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0192243
fix: isGroupHandle now correctly detects group chats
Feb 6, 2026
bb23958
fix: align group-handle test expectation (#42) (thanks @shivshil)
steipete Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- fix: apply history filters before limit (#20, thanks @tommybananas)
- fix: flush watch output immediately when stdout is buffered (#43, thanks @ccaum)
- feat: include `thread_originator_guid` in message output (#39, thanks @ruthmade)
- fix: detect groups from `;+;` prefix in guid/identifier for RPC payloads (#42, thanks @shivshil)

## 0.4.0 - 2026-01-07
- feat: surface audio message transcriptions (thanks @antons)
Expand Down
3 changes: 1 addition & 2 deletions Sources/imsg/RPCPayloads.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ func reactionPayload(_ reaction: Reaction) -> [String: Any] {
}

func isGroupHandle(identifier: String, guid: String) -> Bool {
let handle = identifier.isEmpty ? guid : identifier
return handle.contains(";+;") || handle.contains(";-;")
return guid.contains(";+;") || identifier.contains(";+;")
}

func stringParam(_ value: Any?) -> String? {
Expand Down
2 changes: 1 addition & 1 deletion Tests/imsgTests/RPCPayloadsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Testing
@Test
func isGroupHandleFlagsGroup() {
#expect(isGroupHandle(identifier: "iMessage;+;chat123", guid: "") == true)
#expect(isGroupHandle(identifier: "", guid: "iMessage;-;chat999") == true)
#expect(isGroupHandle(identifier: "", guid: "iMessage;-;chat999") == false)
#expect(isGroupHandle(identifier: "+1555", guid: "") == false)
}

Expand Down